Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feenkcom PythonBridge extensions #10

Open
wants to merge 66 commits into
base: master
Choose a base branch
from

Conversation

akgrant43
Copy link

As discussed:

  • Signal python exceptions in the calling process, not the server process (which effectively locked the image)
  • Don't hang if stdout / stderr subprocess output exceeds buffer size.
  • Allow the runtime files to be easily copied to a separate location (doesn't require git repository to be present, and doesn't modify the git repository; removes the circular symbolic link)
  • Allow the pipenv path and working directory to be specified in the settings. (Especially useful on Mac where there doesn't appear to be a standard python installation).
  • Add support for the DAP debugger
  • Add support for custom proxy classes.
  • Automatically stop the python server on pharo shutdown.
  • Report error information from the subprocess when something goes wrong (not demoed).
  • Fix a few of the automated tests.

akgrant43 and others added 30 commits January 8, 2021 10:25
Run installation script with pipenv on PATH
akgrant43 and others added 30 commits March 22, 2021 08:50
[Enh]: Start if Needed on `uniqueInstance` Access
To avoid "bridge not running" when quitting and then restarting an image.
So that there isn't a circular symbolic link and it is possible to
easily copy just the runtime files without copying the entire git
repository.

Issue: feenkcom/gtoolkit#1936
Allowing the runtime source to be packaged in a custom location.

Issue: feenkcom/gtoolkit#1936
Initial version only reports basic information.  To be enhanced.
testRMessageWithParams and testRSyncMessage handlers expected a dictionary to be passed, while all other tests expected an association to be passed.    Modify the comparison in those two tests to expect the association for msgpack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants